Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the legacy ResourceSet & SchedulingResources at Raylet #23173

Merged
merged 10 commits into from
Apr 22, 2022

Conversation

Chong-Li
Copy link
Contributor

@Chong-Li Chong-Li commented Mar 15, 2022

Why are these changes needed?

This PR tries to replace the legacy ResourceSet and SchedulingResources (by ResourceRequest and NodeResources respectively) structures at Raylet.

Related issue number

#22854

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@Chong-Li Chong-Li marked this pull request as draft March 15, 2022 06:17
@Chong-Li Chong-Li requested a review from raulchen March 15, 2022 10:53
@stale
Copy link

stale bot commented Apr 14, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added stale The issue is stale. It will be closed within 7 days unless there are further conversation and removed stale The issue is stale. It will be closed within 7 days unless there are further conversation labels Apr 14, 2022
@Chong-Li Chong-Li changed the title Remove legacy ResourceSet at Raylet Replace the legacy ResourceSet at Raylet Apr 20, 2022
@Chong-Li Chong-Li changed the title Replace the legacy ResourceSet at Raylet Replace the legacy ResourceSet & SchedulingResources at Raylet Apr 20, 2022
@Chong-Li Chong-Li marked this pull request as ready for review April 20, 2022 08:31
Copy link
Contributor

@raulchen raulchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except the issue @wumuzi520 mentioned.
Also, is "ResourceSet" still used after this PR? If no, can we also remove it?

@Chong-Li
Copy link
Contributor Author

Chong-Li commented Apr 21, 2022

LGTM, except the issue @wumuzi520 mentioned. Also, is "ResourceSet" still used after this PR? If no, can we also remove it?

There are some left in task_spec. Should it be solved here or leave it when you rename the ResourceRequest to ResourceSet (which is also a TDOO item)? @raulchen I'm ok with either way~

Copy link
Contributor

@wumuzi520 wumuzi520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raulchen raulchen merged commit 1807cff into ray-project:master Apr 22, 2022
@raulchen raulchen deleted the replace_resource_set_raylet branch April 22, 2022 06:46
@scv119
Copy link
Contributor

scv119 commented Apr 22, 2022

Thanks for cleaning it up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants