-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the legacy ResourceSet & SchedulingResources at Raylet #23173
Replace the legacy ResourceSet & SchedulingResources at Raylet #23173
Conversation
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except the issue @wumuzi520 mentioned.
Also, is "ResourceSet" still used after this PR? If no, can we also remove it?
There are some left in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for cleaning it up! |
Why are these changes needed?
This PR tries to replace the legacy
ResourceSet
andSchedulingResources
(byResourceRequest
andNodeResources
respectively) structures at Raylet.Related issue number
#22854
Checks
scripts/format.sh
to lint the changes in this PR.