Revert "Revert "[Client] chunked get requests (#22455)"" #23261
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Reverts #22455
PR was originally reverted because it coincided with timeouts in test_remote_package_uri. I suspect the originally PR wasn't the cause of flakiness, since the only parts that this PR could affect in that test is in the codepath for synchronous gets, and it seems unlikely that breaking synchronous gets would only break a single test.
Tested this revert multiple times against CI in #22713 and was unable to reproduce flakiness.
To be extra careful, added two changes (diff can be seen here):
_get_object_iterator
once all chunks are yieldedRelated issue number
Checks
scripts/format.sh
to lint the changes in this PR.