-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up ray-ml requirements #23325
Merged
Merged
Clean up ray-ml requirements #23325
Changes from 13 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
f4c8b14
Unpin tensorflow
ddelange 164eed5
Clean up requirements_ml_docker
ddelange 10474d2
Bump 2.6.2<=tensorflow<2.6.*
ddelange 29ae855
One big pip install command
ddelange 40cf14b
Typo
ddelange 4d2cde8
Typo
ddelange a35ebc9
Allow bugfix releases of tensorflow-probability
ddelange e466fb2
Fix compatibility between rllib and train reqs
ddelange 7e807a3
Add back -U
ddelange b482d7f
Merge branch 'ray-project:master' into patch-1
ddelange a19cbd6
Merge branch 'ray-project:master' into patch-1
ddelange e57f5ec
Apply suggestions from code review
ddelange d5e322f
PR Suggestion
ddelange ac8a2fb
Revert tensorflow to 2.6.2
ddelange 4af1217
Merge branch 'ray-project:master' into patch-1
ddelange f6b0105
Install requirements_dl.txt in CI
ddelange 25d6bf1
Merge branch 'ray-project:master' into patch-1
ddelange 42767be
Leftover
ddelange File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -85,7 +85,6 @@ pytest-lazy-fixture | |
pytest-timeout | ||
pytest-virtualenv | ||
scikit-learn==0.22.2 | ||
tensorflow==2.5.1 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. does this change need to be documented anywhere? |
||
testfixtures | ||
werkzeug | ||
xlrd | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,15 @@ | ||
# These requirements are used for the CI and CPU-only Docker images so we install CPU only versions of torch. | ||
# For GPU Docker images, you should install requirements_ml_docker.txt instead. | ||
# For GPU Docker images, you should install requirements_ml_docker.txt afterwards. | ||
|
||
tensorflow==2.6.3 | ||
tensorflow-probability==0.14.1 | ||
|
||
# If you make changes to this file, please also change `requirements_ml_docker.txt`! | ||
|
||
|
||
# TODO(amogkam): Remove after https://github.com/tensorflow/tensorflow/issues/52922 is fixed. | ||
keras==2.6.0 | ||
tensorflow==2.6.0 | ||
tensorflow-probability==0.14.0 | ||
# If you make changes below this line, please also change `requirements_ml_docker.txt`! | ||
|
||
torch==1.9.0;sys_platform=="darwin" | ||
torchvision==0.10.0;sys_platform=="darwin" | ||
|
||
# On non-OSX machines only install CPU version of torch and torchvision | ||
-f https://download.pytorch.org/whl/torch_stable.html | ||
torch==1.9.0+cpu;sys_platform!="darwin" | ||
-f https://download.pytorch.org/whl/torch_stable.html | ||
torchvision==0.10.0+cpu;sys_platform!="darwin" | ||
torchvision==0.10.0+cpu;sys_platform!="darwin" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thanks for doing this!