[RLlib] Pin Gym Everywhere and turn off gpu for recsim tests #23452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjoliver
approved these changes
Mar 24, 2022
|
Cherrypicked to 1.12.0rc1. |
krfricke
pushed a commit
to krfricke/ray
that referenced
this pull request
Apr 4, 2022
architkulkarni
pushed a commit
that referenced
this pull request
Apr 8, 2022
* [release tests] Pin gym everywhere (#23349) * [rllib] Pin gym everywhere (#23384) This PR Pins gym in the app config.yaml's for rllib and tune so that release tests are no longer broken by the new gym version. * [RLlib] Pin Gym Everywhere and turn off gpu for recsim tests (#23452) * [ci] Clean up ray-ml requirements (#23325) In https://github.com/ray-project/ray/blob/ray-1.11.0/docker/ray-ml/Dockerfile, the order of pip install commands currently matters (potentially a lot). It would be good to run one big pip install command to avoid ending up with a broken env. Co-authored-by: Kai Fricke <[email protected]> * Fix merge conflict * Also copy requirements_train.txt Co-authored-by: Avnish Narayan <[email protected]> Co-authored-by: ddelange <[email protected]> Co-authored-by: Amog Kamsetty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gym wasn't pinned for some PBT tests, and somehow recsim for torch gpu is broken despite #23276 and #22738
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.