-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] [serve] Extended Gradio notebook example for Ray Serve deployments #23494
Conversation
Signed-off-by: Max Pumperla <[email protected]>
doc/source/serve/tutorials/.ipynb_checkpoints/gradio-checkpoint.ipynb
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,364 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we do myst instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with myst the problem is that we don't get the Colab launch button (and binder is also strange in terms of integration). So I'd prefer ipynb, like in Tune.
content looks good. We can have exactly the same thing with Streamlit |
@simon-mo thanks. yeah, was thinking the same re: streamlit, which is actually more complex. Might be good for a more involved example. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are two simple items blocking merge:
- ipynb_checkpoints should not be committed
- images should be in https://github.com/ray-project/images to reduce ray project repo size.
please let me know if you need other help here.
Signed-off-by: Max Pumperla <[email protected]>
@simon-mo removed the checkpoints, forgot about that. Never heard about that image repo before. are we sure this is blocking? |
Signed-off-by: Max Pumperla <[email protected]>
merging masters to re-run the tests |
Signed-off-by: Max Pumperla [email protected]
New Serve example showing how to hook into Gradio interfaces to easily visualise deployments.
Notebook preview