Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Train] Raise helpful error when required backend isn't installed #23583

Merged
merged 2 commits into from
Apr 11, 2022
Merged

[Train] Raise helpful error when required backend isn't installed #23583

merged 2 commits into from
Apr 11, 2022

Conversation

bveeramani
Copy link
Member

Why are these changes needed?

Related issue number

Closes #22347

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@bveeramani bveeramani marked this pull request as draft March 30, 2022 06:58
@bveeramani bveeramani changed the title Raise helpful error when required backend isn't installed [Train] Raise helpful error when required backend isn't installed Mar 30, 2022
@bveeramani bveeramani closed this Mar 30, 2022
@bveeramani bveeramani reopened this Mar 30, 2022
@bveeramani bveeramani marked this pull request as ready for review March 30, 2022 17:54
amogkam
amogkam approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@amogkam amogkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think you need to merge in master to resolve the lint failure

matthewdeng
matthewdeng approved these changes Mar 31, 2022
View reviewed changes
python/ray/train/horovod.py
from horovod.ray.runner import Coordinator
from horovod.ray.utils import detect_nics, nics_to_env_var
from horovod.runner.common.util import secret, timeout
try:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can add test in test_minimal.py

@amogkam amogkam merged commit 394e5ec into ray-project:master Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amogkam amogkam amogkam approved these changes

@matthewdeng matthewdeng matthewdeng approved these changes

Assignees

@matthewdeng matthewdeng

@amogkam amogkam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[train] raise helpful error when required backend isn't installed
3 participants
@bveeramani @matthewdeng @amogkam