[scheduler][6] Integrate ray with syncer. #23660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishbone
requested review from
wuisawesome,
ericl,
AmeerHajAli,
robertnishihara,
pcmoritz,
raulchen,
scv119 and
mwtian
as code owners
fishbone
changed the title
|
Previous prototype: #22073 |
fishbone
removed
the
@author-action-required
fishbone
added
the
@author-action-required
fishbone
removed
the
@author-action-required
|
I offline synced with @WangTaoTheTonic to fill some gaps here. There are some issues with the resource data which require more effort to do and do not fit into the scope of syncer PR. @WangTaoTheTonic is willing to offer some help on that. Finally this PR is ready for another round of review. @scv119 @rkooo567 @jjyao @WangTaoTheTonic please give it another look. |
|
Will take a look this weekend! |
jjyao
reviewed
May 6, 2022
| @@ -45,7 +45,7 @@ class NodeState { | |||
| /// \param cid The component id to take the snapshot. | |||
There was a problem hiding this comment.
This also needs to be updated.
| rpc::ResourcesData resources; | ||
| resources.ParseFromString(message->sync_message()); | ||
| resources.set_node_id(message->node_id()); | ||
| RAY_CHECK(message->message_type() == syncer::MessageType::RESOURCE_MANAGER); |
There was a problem hiding this comment.
Should message type be resource_report or resource_view?
scv119
added
the
@author-action-required
jjyao
approved these changes
May 9, 2022
| RAY_CHECK(message_type == syncer::MessageType::RESOURCE_MANAGER); | ||
| // We check the memory inside version, so version is not a const function. | ||
| // Ideally, we need to move the memory check somewhere else. | ||
| // TODO(iycheng): Make version as a const function. |
There was a problem hiding this comment.
this needs to be updated as well.
| rpc::ResourcesData resources; | ||
| resources.ParseFromString(message->sync_message()); | ||
| resources.set_node_id(message->node_id()); | ||
| RAY_CHECK(message->message_type() == syncer::MessageType::RESOURCE_MANAGER); |
fishbone
force-pushed
the
syncer-integration
branch
from
9f150c5
to
2d62286
Compare
fishbone
force-pushed
the
syncer-integration
branch
from
2d62286
to
77710ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The new syncer comes with the feature of long-polling and versioning. This PR integrates it with ray.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.