[AIR] Add config to Result, extend ResultGrid.get_best_config
#23698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogkam
approved these changes
Apr 4, 2022
| @@ -14,11 +14,15 @@ def f(config): | |||
| with open(path, "w") as f: | |||
| f.write(json.dumps({"step": 0})) | |||
|
|
|||
| analysis = tune.run(f) | |||
| analysis = tune.run(f, config={"a": 1}) | |||
There was a problem hiding this comment.
Not needed for this PR, but should we move test_result_grid to ray.ml.tests and have it use Tuner instead of tune.run?
xwjiang2010
approved these changes
Apr 4, 2022
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Apr 7, 2022
…ay-project#23698) Adds a dynamic property to easily obtain `config` dict from `Result`, extends the `ResultGrid.get_best_config` method for parity with `ExperimentAnalysis.get_best_trial` (allows for using of mode and metric different to the one set in the Tuner).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Adds a dynamic property to easily obtain
configdict fromResult, extends theResultGrid.get_best_configmethod for parity withExperimentAnalysis.get_best_trial(allows for using of mode and metric different to the one set in the Tuner).Related issue number
Checks
scripts/format.shto lint the changes in this PR.