Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Issue 23639: Error in client/server setup when using LSTMs #23740

Merged
merged 2 commits into from
Apr 7, 2022
Merged

[RLlib] Issue 23639: Error in client/server setup when using LSTMs #23740

merged 2 commits into from
Apr 7, 2022

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Apr 6, 2022 •
edited
Loading

Issue 23639: Error in client/server setup when using LSTMs

  • Added LSTM test case for the client/server.sh scripts using CartPole and IMPALA (+LSTM)

Also see this issue here:
#23639

Why are these changes needed?

Issue #23639

Related issue number

Close #23639

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

gjoliver
gjoliver approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@gjoliver gjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cleanup!!

@sven1977 sven1977 merged commit 0b3a79c into ray-project:master Apr 7, 2022
edoakes pushed a commit to edoakes/ray that referenced this pull request Apr 7, 2022
@sven1977 @edoakes
[RLlib] Issue 23639: Error in client/server setup when using LSTMs (r…
e70a7a6 
…ay-project#23740)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjoliver gjoliver gjoliver approved these changes

@avnishn avnishn Awaiting requested review from avnishn

@ArturNiederfahrenhorst ArturNiederfahrenhorst Awaiting requested review from ArturNiederfahrenhorst

@smorad smorad Awaiting requested review from smorad

Assignees

@avnishn avnishn

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@sven1977 @gjoliver @avnishn