-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Datasets] [Hotfix] Add ray_remote_args to read_text. #23764
[Datasets] [Hotfix] Add ray_remote_args to read_text. #23764
Conversation
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
|
Will be coming back to this in the next week or so. |
fc9ae40
to
bb0bbac
Compare
# Conflicts: # python/ray/data/tests/test_dataset_formats.py
I've taken a look.
This all passes locally for me every time now. See these changes: 7b4ee95 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bit of a self-accept but still - cc @clarkzinzow to merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krfricke Thanks a million for finding the blocker bug! Definitely a 🤦 moment for me. 😁
I think this is good to merge, with a P2 follow-up around adding a TextDatasource
to get rid of this two-stage read.
Adds
ray_remote_args
toray.data.read_text()
. This exists on all otherray.data.read_*
APIs, so it appears thatread_text()
was missed.Checks
scripts/format.sh
to lint the changes in this PR.