[workflow] Deprecate "workflow.step" [Part 3 - events] #23796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishbone
reviewed
Apr 8, 2022
| @@ -305,6 +305,9 @@ def __setstate__(self, n): | |||
| # guarentee obj1's finish. | |||
| obj1 = c.incr.run_async(10) # noqa | |||
| obj2 = c.incr.run(10) # noqa | |||
| # TODO(suquark): The test is flaky sometimes (only on CI), which might indicates | |||
| # some bugs. This is a workaroundde temporarily. | |||
There was a problem hiding this comment.
Do you want to file an issue and fix this?
There was a problem hiding this comment.
The related issue: #23760
fishbone
approved these changes
Apr 8, 2022
|
The workflow failure in the test is related to #23760 and is not related to this PR. I'll merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR follows #23728
Related issue number
Checks
scripts/format.shto lint the changes in this PR.