Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enable gcs actor scheduler 1/n] Raylet and GCS schedulers share cluster_task_manager #23829

Merged
merged 26 commits into from
May 2, 2022
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 2 additions & 19 deletions BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -1786,10 +1786,10 @@ cc_test(
)

cc_test(
name = "raylet_based_actor_scheduler_test",
name = "gcs_actor_scheduler_test",
size = "small",
srcs = [
"src/ray/gcs/gcs_server/test/raylet_based_actor_scheduler_test.cc",
"src/ray/gcs/gcs_server/test/gcs_actor_scheduler_test.cc",
],
copts = COPTS,
tags = ["team:core"],
Expand Down Expand Up @@ -1818,23 +1818,6 @@ cc_test(
],
)

cc_test(
name = "gcs_based_actor_scheduler_test",
size = "small",
srcs = [
"src/ray/gcs/gcs_server/test/gcs_based_actor_scheduler_test.cc",
],
copts = COPTS,
tags = ["team:core"],
deps = [
":gcs_server_lib",
":gcs_server_test_util",
":gcs_test_util_lib",
":ray_mock",
"@com_google_googletest//:gtest_main",
],
)

cc_test(
name = "gcs_actor_manager_test",
size = "small",
Expand Down
9 changes: 5 additions & 4 deletions python/ray/tests/test_advanced_5.py
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ def test_actor_distribution_balance(ray_start_cluster_enabled, args):
ray.init(address=cluster.address)
cluster.wait_for_nodes()

@ray.remote(memory=100 * 1024 ** 2, num_cpus=0.01)
@ray.remote(memory=100 * 1024 ** 2, num_cpus=0.01, scheduling_strategy="SPREAD")
scv119 marked this conversation as resolved.
Show resolved Hide resolved
class Foo:
def method(self):
return ray.worker.global_worker.node.unique_id
Expand Down Expand Up @@ -194,16 +194,17 @@ def test_worker_lease_reply_with_resources(ray_start_cluster_enabled):
cluster = ray_start_cluster_enabled
cluster.add_node(
memory=2000 * 1024 ** 2,
num_cpus=1,
_system_config={
"gcs_resource_report_poll_period_ms": 1000000,
"gcs_actor_scheduling_enabled": True,
},
)
node2 = cluster.add_node(memory=1000 * 1024 ** 2)
node2 = cluster.add_node(memory=1000 * 1024 ** 2, num_cpus=1)
ray.init(address=cluster.address)
cluster.wait_for_nodes()

@ray.remote(memory=1500 * 1024 ** 2)
@ray.remote(memory=1500 * 1024 ** 2, num_cpus=0.01)
Chong-Li marked this conversation as resolved.
Show resolved Hide resolved
def fun(signal):
signal.send.remote()
time.sleep(30)
Expand All @@ -214,7 +215,7 @@ def fun(signal):
# Make sure that the `fun` is running.
ray.get(signal.wait.remote())

@ray.remote(memory=800 * 1024 ** 2)
@ray.remote(memory=800 * 1024 ** 2, num_cpus=0.01)
class Foo:
def method(self):
return ray.worker.global_worker.node.unique_id
Expand Down
293 changes: 0 additions & 293 deletions src/ray/gcs/gcs_server/gcs_actor_distribution.cc

This file was deleted.

Loading