Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tune] Fix memory resources for head bundle #23861

Merged
merged 2 commits into from
Apr 12, 2022
Merged

[tune] Fix memory resources for head bundle #23861

merged 2 commits into from
Apr 12, 2022

Conversation

Yard1
Copy link
Member

@Yard1 Yard1 commented Apr 12, 2022

Why are these changes needed?

Fixes memory and object_store_memory actor options not being set properly for the Tune trainable.

Related issue number

Closes #23528

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@krfricke krfricke merged commit ff60ebd into ray-project:master Apr 12, 2022
@Yard1 Yard1 deleted the tune_fix_memory_in_head_bundle branch April 18, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krfricke krfricke krfricke approved these changes

@xwjiang2010 xwjiang2010 Awaiting requested review from xwjiang2010

Assignees

@krfricke krfricke

@xwjiang2010 xwjiang2010

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] support set memory limit in ray tune
3 participants
@Yard1 @krfricke @xwjiang2010