[core] Simplify options handling [Part 2] #23882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suquark
commented
Apr 13, 2022
| # decorator. Last three conditions are to check that no resources were | ||
| # specified when _remote() was called. | ||
| if ( | ||
| num_cpus is None |
There was a problem hiding this comment.
The original implementation is kind of buggy: It does not consider the case of "memory". "memory" should also be considered as a resource.
suquark
commented
Apr 13, 2022
| @@ -2112,7 +2112,6 @@ def _mode(worker=global_worker): | |||
|
|
|||
|
|
|||
| def _make_remote(function_or_class, options): | |||
| # filter out placeholders in options | |||
There was a problem hiding this comment.
remove unexpected comment. I forgot to remove it last time.
suquark
changed the title
jjyao
reviewed
Apr 13, 2022
jjyao
added
the
@author-action-required
suquark
force-pushed
the
cleanup_ray_options_2
branch
from
ad106a2
to
0b2a5de
Compare
|
I decide to leave Ray Serve for later PRs, since it more related to Ray Serve. I just simply removed changes related to Ray Serve. |
suquark
removed
the
@author-action-required
jjyao
approved these changes
Apr 13, 2022
suquark
force-pushed
the
cleanup_ray_options_2
branch
from
0b2a5de
to
ee57239
Compare
|
All checks pass. I'll merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This is a follow up of #23127.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.