Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Issue 22943: PettingZoo parallel should not use env checking (for now). #24025

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Apr 19, 2022

[RLlib] Issue 22943: PettingZoo parallel should not use env checking (for now).

Why are these changes needed?

Issue #22943

Related issue number

Closes #22943

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Member

@avnishn avnishn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gjoliver
Copy link
Member

should we do this for Unity as well?? #24016

…e_22943_petting_zoo_parallel_env_should_skip_env_checking_for_now
@sven1977 sven1977 merged commit 14dd7aa into ray-project:master Apr 21, 2022
@sven1977 sven1977 deleted the issue_22943_petting_zoo_parallel_env_should_skip_env_checking_for_now branch June 2, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Error when using PettingZoo Environments with ray==1.11.0
3 participants