[workflow] Enable setting workflow options on Ray DAGs #24210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suquark
requested review from
ericl,
fishbone and
stephanie-wang
as code owners
ericl
reviewed
Apr 26, 2022
| "name", | ||
| "metadata", | ||
| "catch_exceptions", | ||
| "max_retries", |
There was a problem hiding this comment.
Shouldn't max retries be unified?
There was a problem hiding this comment.
I am not sure if it can be/should be unified. The max_retries in workflow retries at the python program layer and does not catch failures beyond normal exceptions. @iycheng
There was a problem hiding this comment.
The semantics is different. I'd say either leave two APIs here or we give ray's max retries some default value.
suquark
changed the title
|
LGTM. I feel right now since we have already had to isolate workflow options with ray options, it's reasonable to put |
ericl
approved these changes
Apr 26, 2022
ericl
added
the
@author-action-required
|
The CI errors are not related. The MacOS errors are due to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR enables setting workflow options on Ray DAGs.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.