[GCS][Storage unification 3/n] Deprecate MemoryInternalKV, use StoreClientInternalKV<MemoryStoreClient> instead #24211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scv119
changed the title
scv119
changed the title
scv119
changed the title
fishbone
reviewed
Apr 27, 2022
Comment on lines
447
to
452
| if (storage_type_ == "redis") { | ||
| instance = std::make_unique<RedisInternalKV>(GetRedisClientOptions()); | ||
| } else if (storage_type_ == "memory") { | ||
| instance = std::make_unique<MemoryInternalKV>(main_service_); | ||
| instance = std::make_unique<StoreClientInternalKV>( | ||
| std::make_unique<InMemoryStoreClient>(main_service_)); | ||
| } |
There was a problem hiding this comment.
Why not just use store clients here? Also for redis.
There was a problem hiding this comment.
yeah I think this will mostly impact Ant. cc @raulchen to see if we should turn it on by default.
fishbone
reviewed
Apr 27, 2022
fishbone
added
the
@author-action-required
Yeah I think it's because of |
|
My feeling is that we should hide the underline store from internal kv and it should be built upon StoreClient directly. In the end, the store client will be used by table and kv. We can use memory or Redis as the backend of the store client. |
rkooo567
approved these changes
Apr 28, 2022
scv119
added
the
tests-ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In this PR, we deprecated MemoryInternalKV. Instead, we use a wrapper that wraps around MemoryStoreClient. This PR is build upon #23754 and #23725
Related issue number
Checks
scripts/format.shto lint the changes in this PR.