Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[RLlib] APPO eager fix (APPOTFPolicy gets wrapped `as_eager()… #24280

Closed
wants to merge 1 commit into from

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Apr 28, 2022

…` twice by mistake). (#24268)"

This reverts commit c95dd79.

Why are these changes needed?

It breaks linux://rllib:test_alpha_star

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@gjoliver
Copy link
Member

looking.
I kind of think we comment out the alphastar test for now, instead of reverting this pr.
nobody uses alphastar while appo is a much popular agent.

@jjyao
Copy link
Collaborator Author

jjyao commented Apr 28, 2022

It's fixed here: #24271

@jjyao jjyao closed this Apr 28, 2022
@jjyao jjyao deleted the jjyao/rllib branch April 28, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants