Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[workflow] Ensure "get_if_exists" takes effect in the decorator. #24287

Merged
merged 1 commit into from
Apr 28, 2022
Merged

[workflow] Ensure "get_if_exists" takes effect in the decorator. #24287

merged 1 commit into from
Apr 28, 2022

Conversation

suquark
Copy link
Member

@suquark suquark commented Apr 28, 2022

Why are these changes needed?

Currently, "get_if_exists" does not take effect if defined in the decorator.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@suquark suquark changed the title [workflow] Ensure "get_if_exists" makes effect in the decorator. [workflow] Ensure "get_if_exists" takes effect in the decorator. Apr 28, 2022
@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Apr 28, 2022
@suquark suquark merged commit b0f00a1 into ray-project:master Apr 28, 2022
@suquark suquark deleted the enable_skip_if_not_exist_decorator branch April 28, 2022 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericl ericl ericl approved these changes

Assignees

@ericl ericl

Labels
@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suquark @ericl