[RLlib] PGTrainer config object class (PGConfig). #24295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven1977
requested review from
gjoliver,
avnishn,
ArturNiederfahrenhorst and
smorad
as code owners
maxpumperla
reviewed
Apr 28, 2022
| @@ -229,6 +229,20 @@ def to_dict(self) -> TrainerConfigDict: | |||
| config["input"] = getattr(self, "input_") | |||
| config.pop("input_") | |||
|
|
|||
| # Setup legacy multiagent sub-dict: | |||
| config["multiagent"] = {} | |||
| for k in [ | |||
There was a problem hiding this comment.
good catch, didn't think of this one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PGTrainer config object class (PGConfig).
PPOConfig.Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.