[serve] Fix replica leak in anonymous namespaces #24311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoakes
approved these changes
Apr 28, 2022
jiaodong
approved these changes
Apr 28, 2022
shrekris-anyscale
added a commit
to shrekris-anyscale/ray
that referenced
this pull request
Apr 28, 2022
4 tasks
edoakes
pushed a commit
that referenced
this pull request
Apr 29, 2022
#24311 added the `test_update_num_replicas_anonymous_namespace` unit test to check for replica leaks in anonymous namespaces. This change adds this test to the master branch.
|
Lint failing on master |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When Ray starts in an anonymous namespace, replicas don't shut down correctly, causing a replica leak. This change adds fixes introduced in #23896 to Ray 1.12.1, and it adds a new unit test to check replica updates in anonymous namespaces.
Related issue number
Closes #24260.
Checks
scripts/format.shto lint the changes in this PR.test_standalone2.py.