[RLlib] APPO config objects #24376
Merged
[RLlib] APPO config objects #24376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven1977
requested review from
gjoliver,
avnishn,
ArturNiederfahrenhorst,
smorad and
maxpumperla
as code owners
maxpumperla
reviewed
May 2, 2022
rllib/__init__.py
Outdated
| @@ -57,7 +57,7 @@ def setup(self, config): | |||
|
|
|||
| _setup_logger() | |||
|
|
|||
| usage_lib.record_library_usage("rllib") | |||
| # usage_lib.record_library_usage("rllib") | |||
There was a problem hiding this comment.
Could you please explain this? Can we remove it altogether?
There was a problem hiding this comment.
Oh, sorry, this shouldn't be here. Will remove ...
maxpumperla
reviewed
May 2, 2022
rllib/agents/ppo/appo.py
Outdated
| """Defines a A2CTrainer configuration class from which a new Trainer can be built. | ||
|
|
||
| Example: | ||
| >>> from ray import tune |
maxpumperla
requested changes
May 2, 2022
maxpumperla
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APPO config objects
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.