[RLlib] Release learning tests for SlateQ have wrong yaml structure #24429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven1977
requested review from
gjoliver,
avnishn,
ArturNiederfahrenhorst,
smorad and
maxpumperla
as code owners
avnishn
approved these changes
May 3, 2022
| @@ -456,22 +456,18 @@ sac-halfcheetahbulletenv-v0: | |||
| slateq-interest-evolution-recsim-env: | |||
| env: ray.rllib.examples.env.recommender_system_envs_with_recsim.InterestEvolutionRecSimEnv | |||
| run: SlateQ | |||
| stop: | |||
| pass_criteria: | |||
| episode_reward_mean: 162.0 | |||
There was a problem hiding this comment.
This won't run using the rllib cli utility -- is that fine?
There was a problem hiding this comment.
Yeah, that's ok. These are special release tests configs with the additional pass_criteria key.
…ase_tests_slateq_fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pass_criteriamissing,stopmissing.Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.