Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serve] Support serializing numpy scaler #24512

Merged
merged 1 commit into from
May 5, 2022

Conversation

simon-mo
Copy link
Contributor

@simon-mo simon-mo commented May 5, 2022

Why are these changes needed?

In previous PR we unified the existing Starlette and FastAPI custom serializers for numpy arrays. However, it is common for RLlib and other libraries to return a list of numpy scaler values: [np.int(1), np.int(2)]. This PR adds support for that.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@simon-mo simon-mo merged commit a424e91 into ray-project:master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants