[RLlib] MADDPG: Move into main algorithms folder and add proper unit and learning tests.
#24579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven1977
requested review from
gjoliver,
avnishn,
ArturNiederfahrenhorst,
smorad and
maxpumperla
as code owners
sven1977
changed the title
agents folder and transfer to training_iteration API.algorithms folder and add proper unit and learning tests.
avnishn
approved these changes
May 23, 2022
| py_test( | ||
| name = "learning_tests_two_step_game_maddpg", | ||
| main = "tests/run_regression_tests.py", | ||
| tags = ["team:ml", "tf_only", "no_tf_eager_tracing", "learning_tests", "learning_tests_discrete"], |
There was a problem hiding this comment.
Could we maybe instead add this to the weekly ci -- I feel like we don't need to as widely support this algorithm until there is a customer use case.
There was a problem hiding this comment.
Good question: I think we should move toward:
- CI-tests: small tasks that can be learnt in 1-2 min (CartPole, TwoStepGame, maybe Pendulum or simpler cont. actions problem)
- nightly tests: hard tasks, requiring GPU + ~1h of completion on >1 workers
There was a problem hiding this comment.
I'll leave this test here for now to roughly match the other algos' coverage (everyone has CartPole/Pendulum tests in the CI, which is ok).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MADDPG: Move into main
algorithmsfolder and transfer totraining_iterationAPI.Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.