[Autoscaler][Local Node Provider] Log a warning if max_workers < len(worker_ips) #24635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was about to post an issue about it, realized it would be faster to just fix it. |
DmitriGekhtman
commented
May 10, 2022
| @@ -1,11 +1,7 @@ | |||
| cluster_name: default | |||
| min_workers: 0 | |||
| max_workers: 0 | |||
There was a problem hiding this comment.
Don't need to demonstrate non-default autoscaling settings anywhere except example-full.
ckw017
approved these changes
May 10, 2022
|
Test failures unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Follow-up to #21710.
Resolves some of the UX problems expressed in https://stackoverflow.com/questions/72060228/ray-cluster-connection-closed-example-script-displays-127-0-0-1-instead-of-head/72089615?noredirect=1#comment127388667_72089615
Logs a warning when a user sets max_workers for local node provider less than the number of available ips.
Also removes defaults of 0 for min_workers and max_workers from example configs to help prevent users inadvertantly setting
max_workers=0again.Related issue number
Checks
scripts/format.shto lint the changes in this PR.