Allowing passing kwargs #24692
Merged
Allowing passing kwargs #24692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allowing passing kwargs (e.g., `temperature`) to child distributions. Least effort modification, but will break for distros that don't accept the same init keywords. Other options include pass-through kwargs or extending with `child_kwargs`...
nmatare
requested review from
sven1977,
gjoliver,
avnishn,
ArturNiederfahrenhorst,
smorad and
maxpumperla
as code owners
avnishn
approved these changes
May 13, 2022
|
you'll need to run the linting script that we have from the base ray directory |
sven1977
reviewed
May 13, 2022
sven1977
reviewed
May 13, 2022
|
Looks good. Thanks for the fix @nmatare . I just cleaned up the LINT errors. Waiting for tests to pass again ... |
|
Ah, thanks for the linting hint. Will apply that for next time. Yeah, it's not really robust to different init keywords for child distros. The kwargs will break the code in that case. But since this is all going to change anyway, I'm looking forward to the new API! |
|
I don't think there is a strong reason to backport. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing passing kwargs (e.g.,
temperature) to child distributions.Least effort modification, but will break for distros that don't accept the same init keywords. Other options include pass-through kwargs or extending with
child_kwargs...Why are these changes needed?
So that you can pass keywords to child distributions.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.