Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLllib] Policy Server/Client metrics reporting fix #24783

Merged
merged 3 commits into from
May 15, 2022
Merged

[RLllib] Policy Server/Client metrics reporting fix #24783

merged 3 commits into from
May 15, 2022

Conversation

ArturNiederfahrenhorst
Copy link
Contributor

@ArturNiederfahrenhorst ArturNiederfahrenhorst commented May 13, 2022 •
edited
Loading

Why are these changes needed?

Rollout Metrics are not being reported correctly by the policy server.
See for example: this issue or related issue.

Related TB log.
Blue is with fix, orange without.

Related issue number

Closes #21246

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

gjoliver
gjoliver approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@gjoliver gjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow! this is really neat!!
and those folks would be thrilled! thanks a ton man!

@ArturNiederfahrenhorst ArturNiederfahrenhorst mentioned this pull request May 15, 2022
Closed
2 tasks
@sven1977 sven1977 merged commit b1bc435 into ray-project:master May 15, 2022
maxpumperla pushed a commit that referenced this pull request May 18, 2022
@ArturNiederfahrenhorst @maxpumperla
[RLlib] Policy Server/Client metrics reporting fix (#24783)
c361850
@ArturNiederfahrenhorst ArturNiederfahrenhorst deleted the policyserverclientfix branch July 5, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjoliver gjoliver gjoliver approved these changes

@sven1977 sven1977 Awaiting requested review from sven1977 sven1977 is a code owner

@avnishn avnishn Awaiting requested review from avnishn

@smorad smorad Awaiting requested review from smorad

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

@kouroshHakha kouroshHakha Awaiting requested review from kouroshHakha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] cartpole_server.py and cartpole_client.py example recording NaNs
3 participants
@ArturNiederfahrenhorst @gjoliver @sven1977