[RLlib] MAML config objects. #25066
Merged
[RLlib] MAML config objects. #25066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven1977
requested review from
gjoliver,
avnishn,
ArturNiederfahrenhorst,
smorad,
maxpumperla and
kouroshHakha
as code owners
sven1977
added
the
tests-ok
maxpumperla
approved these changes
May 23, 2022
rllib/algorithms/maml/maml.py
Outdated
| >>> config = MAMLConfig() | ||
| >>> # Print out some default values. | ||
| >>> print(config.lr) | ||
| ... 0.0004 |
There was a problem hiding this comment.
ellipses are for continuation of a previous line. I think you need to remove them (and obv. keep the indent) for this to be doc-tested correctly.
Not sure why this doesn't fail, do we turn doctest off somewhere for these examples? Last time I checked it was still part of the docs build.
sven1977
commented
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAML config objects.
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.