Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIR] Directly convert TorchPredictor ndarray inputs to tensors #25190

Merged
merged 9 commits into from
May 27, 2022

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented May 25, 2022

Important: This PR is stacked on:

Why are these changes needed?

If you pass a multidimensional input to TorchPredictor.predict, AIR errors. For more information about the error, see #25194.

Related issue number

Fixes #25194

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@bveeramani bveeramani marked this pull request as draft May 25, 2022 21:32
@bveeramani bveeramani changed the title [AIR] Ignore feature columns for ndarray inputs to TorchPredictor.predict [AIR] Directly convert TorchPredictor ndarray inputs to tensors May 25, 2022
@bveeramani bveeramani marked this pull request as ready for review May 25, 2022 21:55
@bveeramani bveeramani mentioned this pull request May 25, 2022
7 tasks
@bveeramani bveeramani added this to the Ray AIR milestone May 25, 2022
Copy link
Contributor

@amogkam amogkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@amogkam amogkam merged commit 6923354 into ray-project:master May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AIR] TorchPredictor doesn't work with multidimensional inputs
2 participants