Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tune] Allow iterators in tune.grid_search #25220

Merged
merged 2 commits into from
May 26, 2022
Merged

[tune] Allow iterators in tune.grid_search #25220

merged 2 commits into from
May 26, 2022

Conversation

krfricke
Copy link
Contributor

Why are these changes needed?

tune.choice already accepts iterables, the same should be true for tune.grid_search.

Related issue number

Closes #25212

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@krfricke krfricke requested a review from Yard1 May 26, 2022 13:49
@krfricke krfricke merged commit d0dfac5 into ray-project:master May 26, 2022
@krfricke krfricke deleted the tune/grid-iter branch May 26, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yard1 Yard1 Yard1 approved these changes

Assignees

@Yard1 Yard1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tune.grid_search() should accept iterables
2 participants
@krfricke @Yard1