Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLLib] RE3 exploration algorithm TF2 framework support #25221

Merged
merged 26 commits into from
Jul 24, 2022

Conversation

n30111
Copy link
Contributor

@n30111 n30111 commented May 26, 2022

Why are these changes needed?

This fixes the numpy data type issue while using RE3 with tf2 framework. I have added a test for tf2 training in the test file.

Related issue number

N/A

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@n30111 n30111 changed the title RE3 exploration algorithm TF2 framework support [RLLib] RE3 exploration algorithm TF2 framework support May 26, 2022
@n30111
Copy link
Contributor Author

n30111 commented Jun 14, 2022

@gjoliver can you please review this PR, this will be very helpful, as currently tf2 support is breaking.

@gjoliver
Copy link
Member

sorry about the delay, I missed this PR.
can you rebase to master and trigger CI tests again.
I will ping @sven1977 to merge this once tests pass.

@n30111 n30111 requested a review from krfricke as a code owner June 24, 2022 07:14
@n30111
Copy link
Contributor Author

n30111 commented Jun 25, 2022

@gjoliver I have rebased the code, please check.

@sven1977
Copy link
Contributor

Hey @n3011 , thanks so much for the PR! Could you pull from master again and resolve the conflicts? Then we can merge this.

@n30111
Copy link
Contributor Author

n30111 commented Jul 15, 2022

@sven1977 thanks, I have fixed the conflicts.

@n30111
Copy link
Contributor Author

n30111 commented Jul 23, 2022

Hi @gjoliver @sven1977 Any actions required my side in this PR? It would be great to have this feature in ray 2.0. Thanks.

@gjoliver
Copy link
Member

thanks, I will find someone to get this merged.

@richardliaw richardliaw merged commit b32c784 into ray-project:master Jul 24, 2022
@n30111 n30111 deleted the re3_tf2_fix branch July 24, 2022 13:32
Rohan138 pushed a commit to Rohan138/ray that referenced this pull request Jul 28, 2022
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants