[Serve][Doc] Add http endpoint for dag pattern doc #25243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-mo
approved these changes
May 27, 2022
doc/source/serve/deployment-graph/http_endpoint_for_dag_graph.md
Outdated
Show resolved
Hide resolved
jiaodong
reviewed
May 31, 2022
| @@ -0,0 +1,29 @@ | |||
| # Pattern: Http endpoint for dag graph | |||
|
|
|||
| The example shows how to add endpoint for dag graph | |||
There was a problem hiding this comment.
How about something like
"This example shows how to configure ingress component of the deployment graph, such as HTTP endpoint prefix, HTTP to python object input adapter and number of ingress replicas"
jiaodong
reviewed
May 31, 2022
| :language: python | ||
| ``` | ||
|
|
||
| ````{note} |
There was a problem hiding this comment.
hmm i think this should be three ` like ``` ?
There was a problem hiding this comment.
if you have nested, ```` is the way to indicate this is the outter section. (lmk if you know a better solution)
There was a problem hiding this comment.
oh you're nesting them, let me check again on the built html once your latest commit finishes
jiaodong
approved these changes
May 31, 2022
fishbone
added a commit
that referenced
this pull request
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.