Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data] Fix byte size calculation for non-trivial tensors #25264

Merged
merged 1 commit into from
May 31, 2022
Merged

[data] Fix byte size calculation for non-trivial tensors #25264

merged 1 commit into from
May 31, 2022

Conversation

ericl
Copy link
Contributor

@ericl ericl commented May 27, 2022 •
edited
Loading

Why are these changes needed?

The range datasource was incorrectly calculating tensor sizes if the dimensions != (1,).

Broken out from https://github.com/ray-project/ray/pull/25167/files

@ericl ericl added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label May 27, 2022
@clarkzinzow clarkzinzow merged commit c93e37a into ray-project:master May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianoaix jianoaix jianoaix approved these changes

@clarkzinzow clarkzinzow clarkzinzow approved these changes

@scv119 scv119 Awaiting requested review from scv119

@jjyao jjyao Awaiting requested review from jjyao

Assignees

@clarkzinzow clarkzinzow

@jianoaix jianoaix

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericl @clarkzinzow @jianoaix