[Core] Fix node affinity strategy when resource is empty #25344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishbone
approved these changes
Jun 1, 2022
rkooo567
approved these changes
Jun 1, 2022
scv119
added
the
tests-ok
scv119
added a commit
to scv119/ray
that referenced
this pull request
Jun 1, 2022
…#25344) Why are these changes needed? Today, Ray scheduler always pick a random node if the resource requirement is empty, regardless of scheduling policy/strategy. However, for node affinity scheduling policy, we should not pick random policy but try to stick to the node affinity constraints.
|
I approve picking this into 1.13.0 branch |
krfricke
added a commit
that referenced
this pull request
Jun 1, 2022
…5362) * [Core] Fix node affinity strategy when resource is empty (#25344) Why are these changes needed? Today, Ray scheduler always pick a random node if the resource requirement is empty, regardless of scheduling policy/strategy. However, for node affinity scheduling policy, we should not pick random policy but try to stick to the node affinity constraints. * update Co-authored-by: Chen Shen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Today, Ray scheduler always pick a random node if the resource requirement is empty, regardless of scheduling policy/strategy.
However, for node affinity scheduling policy, we should not pick random policy but try to stick to the node affinity constraints.
Related issue number
closes #25323
Checks
scripts/format.shto lint the changes in this PR.