[Datasets] [Hotfix] Fix stats construction for from_* APIs. #25601
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stats construction on the
from_arrow
andfrom_numpy
(andfrom_pandas
with Pandas block support disabled) is currently broken since we weren't resolving the block metadata before passing it to the stats, causing futureds.stats()
calls to fail. This PR fixes this and adds some test coverage.Drivebys
from_pandas()
zero-copy path (metadata fetch only)."from_numpy"
stats stage name to"from_numpy_refs"
, to be consistent with stats for otherfrom_*()
APIs.Checks
scripts/format.sh
to lint the changes in this PR.