[Datasets] Fix tensor extension string formatting (repr). #25768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarkzinzow
requested review from
ericl,
scv119,
jjyao and
jianoaix
as code owners
|
nice, LGTM! @clarkzinzow |
JiahaoYao
approved these changes
Jun 14, 2022
JiahaoYao
reviewed
Jun 14, 2022
clarkzinzow
force-pushed
the
datasets/fix/tensor-array-string-formatter
branch
2 times, most recently
from
8e12fc5
to
f75fc82
Compare
|
@jianoaix Moved the tests, please take a look, thanks! |
clarkzinzow
force-pushed
the
datasets/fix/tensor-array-string-formatter
branch
from
f75fc82
to
067908d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes tensor extension string formatting, e.g. when invoking the DataFrame repr.
Related issue number
Closes #25423
Checks
scripts/format.shto lint the changes in this PR.