[RLlib] Aggregate impala learner info #25856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avnishn
requested review from
sven1977,
gjoliver,
ArturNiederfahrenhorst,
smorad,
maxpumperla,
kouroshHakha and
krfricke
as code owners
ArturNiederfahrenhorst
approved these changes
Jun 16, 2022
sven1977
reviewed
Jun 17, 2022
sven1977
reviewed
Jun 17, 2022
| @@ -795,7 +795,8 @@ def place_processed_samples_on_learner_queue(self) -> None: | |||
|
|
|||
| def process_trained_results(self) -> ResultDict: | |||
| # Get learner outputs/stats from output queue. | |||
There was a problem hiding this comment.
The comment is outdated here. Could you explain via some more one-line comments what we do here?
ArturNiederfahrenhorst
approved these changes
Jun 17, 2022
avnishn
commented
Jun 21, 2022
| @@ -795,7 +795,8 @@ def place_processed_samples_on_learner_queue(self) -> None: | |||
|
|
|||
| def process_trained_results(self) -> ResultDict: | |||
| # Get learner outputs/stats from output queue. | |||
There was a problem hiding this comment.
Suggested change
| # Get learner outputs/stats from output queue. | |
| # Combine learner stats from the learner queue and update relevant timestep counters |
There was a problem hiding this comment.
what do you think of this @sven1977
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aggregate learner infos for impala training step fn
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.