[air] Randomize block order by default to avoid hotspots #25870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarkzinzow
approved these changes
Jun 16, 2022
ericl
commented
Jun 16, 2022
| if config.use_stream_api: | ||
| dataset = dataset.random_shuffle_each_window() | ||
| else: | ||
| dataset = dataset.random_shuffle() |
matthewdeng
reviewed
Jun 16, 2022
Comment on lines
140
to
141
| if conf.randomize_block_order: | ||
| dataset = dataset.randomize_block_order() |
There was a problem hiding this comment.
Should we add randomize_block_order_each_window for the pipelined case?
There was a problem hiding this comment.
Yeah, I was debating that. I guess we may as well in case it helps with randomization, even though it doesn't help with hotspots.
|
Putting a hold on this, since we identified that this is breaking stage fusion from |
This was referenced Jun 24, 2022
|
Closing this for now. |
|
This should be good to go now that fusion is fixed. |
matthewdeng
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Enable block order randomization by default to avoid ingest hotspots when running concurrent trials.