Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib]: Off-Policy Evaluation fixes #25899

Merged
merged 9 commits into from
Jun 21, 2022
Merged

[RLlib]: Off-Policy Evaluation fixes #25899

merged 9 commits into from
Jun 21, 2022

Conversation

Rohan138
Copy link
Contributor

@Rohan138 Rohan138 commented Jun 17, 2022 •
edited
Loading

Hotfixes for OPE methods:

  • Compute mean and stddev for estimators
  • Rename k_fold_cv to train_test_split and add a train_test_split_val parameter
  • torch.squeeze(-1) fixes

Next PR: #25911

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@Rohan138 Rohan138 added rllib RLlib related issues rllib-offline-rl Offline RL problems labels Jun 17, 2022
@Rohan138 Rohan138 self-assigned this Jun 17, 2022
@Rohan138 Rohan138 mentioned this pull request Jun 17, 2022
Closed
@Rohan138 Rohan138 assigned sven1977 and unassigned Rohan138 Jun 18, 2022
@Rohan138 Rohan138 mentioned this pull request Jun 20, 2022
Merged
6 tasks
@sven1977 sven1977 merged commit 28df3f3 into ray-project:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avnishn avnishn avnishn approved these changes

@sven1977 sven1977 Awaiting requested review from sven1977 sven1977 is a code owner

@gjoliver gjoliver Awaiting requested review from gjoliver

@ArturNiederfahrenhorst ArturNiederfahrenhorst Awaiting requested review from ArturNiederfahrenhorst

@smorad smorad Awaiting requested review from smorad

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

@kouroshHakha kouroshHakha Awaiting requested review from kouroshHakha

@krfricke krfricke Awaiting requested review from krfricke

Assignees

@sven1977 sven1977

@avnishn avnishn

Labels
rllib RLlib related issues rllib-offline-rl Offline RL problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rohan138 @avnishn @sven1977