Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Include SampleBatch.T column in all collected batches #25926

Merged

Conversation

ArturNiederfahrenhorst
Copy link
Contributor

Why are these changes needed?

Most view requirements fall short of the SampleBatch.T='t' field, which is not accessed in dummy batch passes of models.
Therefore, this information is excluded from collected sample batches by default.
In most setups, this is not of interest. But it must be included when saving batches for offline learning purposes and for timeslicing of MultiAgentBatches. Our implementation of timeslice() build on availability of the column SampleBatch.T.

This small PR paves the way for my other PR, which needs this information for the replay buffer lockstep mode.

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for unifying this.

@sven1977 sven1977 merged commit e108766 into ray-project:master Jun 21, 2022
@ArturNiederfahrenhorst ArturNiederfahrenhorst deleted the viewrequirementsfix branch July 5, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants