-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib] Move learning_starts logic into execution plans #26032
[RLlib] Move learning_starts logic into execution plans #26032
Conversation
rllib/utils/replay_buffers/tests/test_multi_agent_prioritized_replay_buffer.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh man!! this must have been a tough PR. Thanks a lot for this. There are a couple of major suggestions / todos before it can be merged. We can sync up over slack if you need more clarification. Also one more good PR practice that should become a habit: Please, Please let the reviewer resolve their own comments (If you mark them as resolved then the reviewer may miss their previous comment and it may indeed still be unresolved). It's also mandatory for the reviewer to also mark those comments that have been addressed as resolved and only leave those that are still open issues / not fully addressed. This way the communication is less prone to errors.
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
@ArturNiederfahrenhorst This PR still needs to address all the TODOs |
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once test pass.
…`. (ray-project#26032) Signed-off-by: Stefan van der Kleij <[email protected]>
Why are these changes needed?
learning_starts
should be renamed to something more descriptive:num_steps_sampled_before_learning_starts
Should be moved out of replay buffer config according to our philosophy: Algorithm should define what should happen when, but NOT how it should happen.
num_steps_sampled_before_learning_starts
answers the "when" and "what" questions and should thus be handled and configured on the top Algo level (not inside replay buffers).Checks
scripts/format.sh
to lint the changes in this PR.