Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Move learning_starts logic into execution plans #26032

Merged
merged 55 commits into from
Aug 11, 2022

Conversation

ArturNiederfahrenhorst
Copy link
Contributor

@ArturNiederfahrenhorst ArturNiederfahrenhorst commented Jun 23, 2022

Why are these changes needed?

  • learning_starts should be renamed to something more descriptive: num_steps_sampled_before_learning_starts

  • Should be moved out of replay buffer config according to our philosophy: Algorithm should define what should happen when, but NOT how it should happen. num_steps_sampled_before_learning_starts answers the "when" and "what" questions and should thus be handled and configured on the top Algo level (not inside replay buffers).

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@kouroshHakha kouroshHakha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh man!! this must have been a tough PR. Thanks a lot for this. There are a couple of major suggestions / todos before it can be merged. We can sync up over slack if you need more clarification. Also one more good PR practice that should become a habit: Please, Please let the reviewer resolve their own comments (If you mark them as resolved then the reviewer may miss their previous comment and it may indeed still be unresolved). It's also mandatory for the reviewer to also mark those comments that have been addressed as resolved and only leave those that are still open issues / not fully addressed. This way the communication is less prone to errors.

Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
@kouroshHakha
Copy link
Contributor

@ArturNiederfahrenhorst This PR still needs to address all the TODOs

Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Copy link
Contributor

@kouroshHakha kouroshHakha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once test pass.

@sven1977 sven1977 merged commit 0dceddb into ray-project:master Aug 11, 2022
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
@ArturNiederfahrenhorst ArturNiederfahrenhorst deleted the learningstarts branch September 21, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants