Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serve] Remove extraneous serve.start() in run_graph() task #26096

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

shrekris-anyscale
Copy link
Contributor

Why are these changes needed?

The run_graph() task has been manually starting Serve with serve.start() to forcibly select the "serve" namespace. However, #25575 made all Serve actors start in the "serve" namespace, meaning this call is extraneous. serve.run() will call serve.start() anyways. This change removes serve.start() from the run_graph() task.

Related issue number

N/A

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • This change relies on existing tests.

@shrekris-anyscale shrekris-anyscale changed the title [WIP] [Serve] Remove extraneous serve.start() in run_graph() task [Serve] Remove extraneous serve.start() in run_graph() task Jun 25, 2022
@simon-mo simon-mo merged commit 66650cd into ray-project:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants