Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] SimpleQ PyTorch Multi GPU fix #26109

Merged
merged 11 commits into from
Jun 28, 2022
Merged

[RLlib] SimpleQ PyTorch Multi GPU fix #26109

merged 11 commits into from
Jun 28, 2022

Conversation

ArturNiederfahrenhorst
Copy link
Contributor

Why are these changes needed?

Multi GPU in SimpleQ is broken

Related issue number

#26105

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@ArturNiederfahrenhorst ArturNiederfahrenhorst added the do-not-merge Do not merge this PR! label Jun 26, 2022
@ArturNiederfahrenhorst ArturNiederfahrenhorst removed the do-not-merge Do not merge this PR! label Jun 27, 2022
@ArturNiederfahrenhorst ArturNiederfahrenhorst changed the title [RLlib] PyTorch Multi GPU Tests [RLlib] SimpleQ PyTorch Multi GPU fix Jun 27, 2022
@ArturNiederfahrenhorst ArturNiederfahrenhorst marked this pull request as ready for review June 27, 2022 06:34
sven1977
sven1977 approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix @ArturNiederfahrenhorst !

@sven1977 sven1977 merged commit efea87f into ray-project:master Jun 28, 2022
sihanwang41 pushed a commit that referenced this pull request Jun 29, 2022
@ArturNiederfahrenhorst @sihanwang41
[RLlib] SimpleQ PyTorch Multi GPU fix (#26109)
764dc1a
@ArturNiederfahrenhorst ArturNiederfahrenhorst deleted the pytorchmultigpu branch July 5, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sven1977 sven1977 sven1977 approved these changes

@gjoliver gjoliver Awaiting requested review from gjoliver

@avnishn avnishn Awaiting requested review from avnishn

@smorad smorad Awaiting requested review from smorad

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

@kouroshHakha kouroshHakha Awaiting requested review from kouroshHakha

@krfricke krfricke Awaiting requested review from krfricke

Assignees

@ArturNiederfahrenhorst ArturNiederfahrenhorst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArturNiederfahrenhorst @sven1977