[RLlib] Added expectation advantage_type to CRR
#26142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kouroshHakha
requested review from
sven1977,
gjoliver,
avnishn,
ArturNiederfahrenhorst,
smorad,
maxpumperla and
krfricke
as code owners
sven1977
reviewed
Jun 28, 2022
| @@ -281,6 +281,20 @@ py_test( | |||
| args = ["--yaml-dir=tuned_examples/crr", '--framework=torch'] | |||
| ) | |||
|
|
|||
| py_test( | |||
sven1977
approved these changes
Jun 28, 2022
There was a problem hiding this comment.
LGTM. Thanks for adding this additional functionality and respective test cases @kouroshHakha !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This allows for analytical advantage computation in discrete action space case.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.