Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serve] Set num_cpus to 0 in run_graph() task #26177

Merged
merged 5 commits into from
Jun 29, 2022

Conversation

shrekris-anyscale
Copy link
Contributor

@shrekris-anyscale shrekris-anyscale commented Jun 28, 2022

Why are these changes needed?

The Serve REST API launches an intermediate Ray task when running a deployment graph. #25861 revealed that this task currently consumes CPUs, reducing the available resources on the Ray cluster without notifying the user. This change sets the task's num_cpus to 0, similar to the ServeController actor.

Related issue number

N/A

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
      • This change adds test_run_graph_task_uses_zero_cpus to test_standalone.py.

Copy link
Contributor

@brucez-anyscale brucez-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simon-mo simon-mo merged commit d1c9aaa into ray-project:master Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants