[AIR] Update TensorflowPredictor to new API #26215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogkam
requested review from
maxpumperla,
pcmoritz,
richardliaw,
edoakes,
simon-mo and
ericl
as code owners
6 tasks
krfricke
reviewed
Jul 2, 2022
xwjiang2010
reviewed
Jul 7, 2022
| @@ -121,36 +153,7 @@ def build_model(self): | |||
|
|
|||
| predictions = predictor.predict(data) | |||
There was a problem hiding this comment.
Can we also comment on what is the return type of predictions?
There was a problem hiding this comment.
Updated the docstring!
There was a problem hiding this comment.
thanks, just for my own understanding...
so say the input is a pd frame with column "age", "salary", it will be converted into multiple tensors and the model should be expecting that?
Another question I have is if the input is image, what does the predict function take and how's everything converted?
There was a problem hiding this comment.
regardless of image or tabular etc.
if it is is a single column dataframe, then it will be converted to a single tensor before being inputted to the model.
if it is a multi column dataframe, then it will be converted to a dict of tensors before being inputted to the model.
| @@ -520,6 +340,14 @@ | |||
| " df = df.drop([\"trip_start_timestamp\"], axis=1)\n", | |||
| " return df\n", | |||
| "\n", | |||
| " def concat_for_tensor(dataframe):\n", | |||
There was a problem hiding this comment.
Is this supposed to be written by user?
xwjiang2010
approved these changes
Jul 8, 2022
…te-tensorflow-predictor-2
richardliaw
approved these changes
Jul 8, 2022
truelegion47
pushed a commit
to truelegion47/ray
that referenced
this pull request
Jul 9, 2022
* master: (42 commits) [dashboard][2/2] Add endpoints to dashboard and dashboard_agent for liveness check of raylet and gcs (ray-project#26408) [Doc] Fix docs feedback button (ray-project#26402) [core][1/2] Improve liveness check in GCS (ray-project#26405) [RLlib] Checkpoint and restore connectors. (ray-project#26253) [Workflow] Minor refactoring of workflow exceptions (ray-project#26398) [workflow] Workflow queue (ray-project#24697) [RLlib] Minor simplification of code. (ray-project#26312) [AIR] Update TensorflowPredictor to new API (ray-project#26215) [RLlib] Make Dataset reader default reader and enable CRR to use dataset (ray-project#26304) [runtime_env] [doc] Remove outdated info about "isolated" environment (ray-project#26314) [Doc] Fix rate-the-docs plugin (ray-project#26384) [Docs] [Serve] Has a consistent landing page style (ray-project#26029) [dashboard] Add `RAY_CLUSTER_ACTIVITY_HOOK` to `/api/component_activities` (ray-project#26297) [tune] Use `Checkpoint.to_bytes()` for store_to_object (ray-project#25805) [tune] Fix `SyncerCallback` having a size limit (ray-project#26371) [air] Serialize additional files in dict checkpoints turned dir checkpoints (ray-project#26351) [Docs] Add "rate the docs" plugin for feedback on docs (ray-project#26330) [Doc] Fix actor example (ray-project#26381) Set RAY_USAGE_STATS_EXTRA_TAGS for release tests (ray-project#26366) [Datasets] Update docs for drop_columns and fix typos (ray-project#26317) ...
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
Updates TensorflowPredictor to use the new _predict_pandas API. Also as agreed upon offline, removes the extra configurations from TensorflowPredictor (column selection, concatenation) in favor of having this be done via a Preprocessor. Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates TensorflowPredictor to use the new
_predict_pandasAPI.Also as agreed upon offline, removes the extra configurations from
TensorflowPredictor(column selection, concatenation) in favor of having this be done via a Preprocessor.Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.