Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++ worker] Refine worker context and more #26281

Merged
merged 2 commits into from
Jul 5, 2022
Merged

[C++ worker] Refine worker context and more #26281

merged 2 commits into from
Jul 5, 2022

Conversation

kfstorm
Copy link
Member

@kfstorm kfstorm commented Jul 4, 2022 •
edited
Loading

Why are these changes needed?

  • Avoid depending on CoreWorkerProcess::GetCoreWorker() in local mode.
  • Fix bug in LocalModeObjectStore::PutRaw.
  • Remove unused TaskExecutor::Execute method.
  • Use Process::Wait instead of sleep when invoking ray start and ray stop.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@kfstorm kfstorm requested a review from SongGuyang July 4, 2022 09:07
SongGuyang
SongGuyang approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@SongGuyang SongGuyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for these fixes.

@kfstorm
Copy link
Member Author

kfstorm commented Jul 5, 2022

io.ray.test.CrossLanguageInvocationTest.testCallingCppActor and test_output fail on master as well.

@kfstorm kfstorm merged commit 7ea9d91 into ray-project:master Jul 5, 2022
@kfstorm kfstorm deleted the cpp_worker_refine branch July 5, 2022 05:47
truelegion47 pushed a commit to truelegion47/ray that referenced this pull request Jul 6, 2022
Merge branch 'master' into ISSUE-24869
dada6cb 
* master: (104 commits)
  [Serve] Java Client API and End to End Tests (ray-project#22726)
  [Docs] Small fix to AIR examples descriptions (ray-project#26227)
  [Deployment Graph] Move `Deployment` creation outside to build function (ray-project#26129)
  [K8s][Ray Operator] Ignore resource requests when detected container resources. (ray-project#26234)
  Revert "[Core] Add retry exception allowlist for user-defined filteri… (ray-project#26289)
  [ci] pin gpustat (ray-project#26311)
  [tune] fix `set_tune_experiment` (ray-project#26298)
  Revert "Revert "[AIR][Serve] Rename ModelWrapperDeployment -> PredictorDeployment"" (ray-project#26231)
  [Release] Use nightly base images for release tests (ray-project#25373)
  Revert "[Core] fix gRPC handlers' unlimited active calls configuration (ray-project#25626)" (ray-project#26202)
  [RLlib] Some Docs fixes (2). (ray-project#26265)
  [C++ worker] Refine worker context and more (ray-project#26281)
  Fix file_system_monitor.cc message (ray-project#26143)
  [Java] Make Java test more stable (ray-project#26282)
  [air] Do not warn of `checkpoint_dir` if it's coming from us (base_trainer). (ray-project#26259)
  [Datasets] Support drop_columns API (ray-project#26200)
  [Datasets] Fix max number of actors for default actor pool strategy (ray-project#26266)
  [ci] Stop syncer staging tests (ray-project#26273)
  [core][gcs] Add storage namespace to redis storage in GCS. (ray-project#25994)
  [workflow] Deprecate workflow.create (ray-project#26106)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SongGuyang SongGuyang SongGuyang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kfstorm @SongGuyang