-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Serve][Part1] Update the tests to use graph deploy #26310
Conversation
@sihanwang41 can you explain in more detail the problem when you don't include the |
I think the behavior we want is for redeploying the graph to cause all replicas to be restarted. |
does it mean when user want to change num_replicas from 100 to 200, we will have to recreate all replicas? @edoakes this is what i test. After change replicas to 3, all old exsiting replicas will be destroyed
|
Synced with @edoakes offline, revert version tests. |
Signed-off-by: Stefan van der Kleij <[email protected]>
Why are these changes needed?
Related issue number
Checks
scripts/format.sh
to lint the changes in this PR.