[Train] Add support for handling multiple batch data types for prepare_data_loader #26386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VishDev12
changed the title
…oader in ray.train.torch
matthewdeng
reviewed
Jul 8, 2022
Co-authored-by: matthewdeng <[email protected]>
amogkam
reviewed
Jul 8, 2022
There was a problem hiding this comment.
Thanks @VishDev12! Do you think you can also add a test for this? There's already a test_torch_prepare_dataloader test in test_gpu.py. We can just use that same test but try with DataLoaders that also output dictionaries instead of just tuples.
|
Hey @amogkam, I've added a dict case in the Please let me know if something doesn't look quite right. |
amogkam
approved these changes
Jul 11, 2022
| @@ -24,6 +24,11 @@ def __len__(self): | |||
| return len(self.x) | |||
|
|
|||
|
|
|||
| class LinearDatasetDict(LinearDataset): | |||
There was a problem hiding this comment.
If this is only used in the test and not part of the example, can we move this to test_gpu directly?
There was a problem hiding this comment.
That makes sense, I've moved it just under the fixtures defined on test_gpu, just to keep the separation between the test_* functions and the rest. But if you want to have it defined just above test_torch_prepare_dataloader, I could do that too.
|
Awesome, thanks @VishDev12! |
6 tasks
6 tasks
amogkam
added a commit
that referenced
this pull request
Jul 26, 2022
…types for prepare_data_loader"" (#26491) Signed-off-by: Amog Kamsetty <[email protected]> * Revert "Revert "[Train] Add support for handling multiple batch data types for prepare_data_loader (#26386)" (#26483)" This reverts commit e6c0403.
Rohan138
pushed a commit
to Rohan138/ray
that referenced
this pull request
Jul 28, 2022
…types for prepare_data_loader"" (ray-project#26491) Signed-off-by: Amog Kamsetty <[email protected]> * Revert "Revert "[Train] Add support for handling multiple batch data types for prepare_data_loader (ray-project#26386)" (ray-project#26483)" This reverts commit e6c0403. Signed-off-by: Rohan138 <[email protected]>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
…e_data_loader (ray-project#26386) When working with Ray Train, using the ray.train.torch.prepare_data_loader method with a dataset that returns a dictionary instead of a tuple from its __getitem__ method causes issues. Co-authored-by: matthewdeng <[email protected]> Signed-off-by: Stefan van der Kleij <[email protected]>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
…r prepare_data_loader (ray-project#26386)" (ray-project#26483) This reverts commit 36229d1. Signed-off-by: Stefan van der Kleij <[email protected]>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
…types for prepare_data_loader"" (ray-project#26491) Signed-off-by: Amog Kamsetty <[email protected]> * Revert "Revert "[Train] Add support for handling multiple batch data types for prepare_data_loader (ray-project#26386)" (ray-project#26483)" This reverts commit e6c0403. Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When working with Ray Train, using the
ray.train.torch.prepare_data_loadermethod with a dataset that returns a dictionary instead of a tuple from its__getitem__method causes issues.Related issue number
Closes #26385
Checks
scripts/format.shto lint the changes in this PR.